lkml.org 
[lkml]   [2012]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v4 1/4] tools: Add Makefile.include
    Hi Borislav.

    Some random comments as I really did not look at this
    part of the patch-set before.

    > +#
    > +# Include saner warnings here, which can catch bugs:
    > +#
    > +EXTRA_WARNINGS := -Wformat
    > +EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wformat-security

    Two general comments - and I know this is just something you copied...
    Why not use the += operator. The below looks like shell script syntax.
    And we use the += operator in other places - at least in the kernel stuff.

    AND WHY ALL THESE SCREAMING CAPITAL LETTERS?
    I know Makefiles and scripts are full of them - but that does not help
    the readability.

    For kbuild I generally shifted to use:
    - lower-case names for local stuff
    - Upper case letters for global stuff - properly prefixed to avoid collisions
    EXTRA_WARNINGS likely fall into the category global-stuff,
    but then a local variable could still be usefull.

    Sam


    \
     
     \ /
      Last update: 2012-04-10 22:29    [W:8.743 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site