Messages in this thread | | | Date | Tue, 10 Apr 2012 21:10:59 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH v2] mm: correctly synchronize rss-counters at exit/exec |
| |
On 04/10, Konstantin Khlebnikov wrote: > > This patch moves sync_mm_rss() into mm_release(), and moves mm_release() out of > do_exit() and calls it earlier. After mm_release() there should be no page-faults.
Can't prove, but I feel there should be a simpler fix...
Anyway, this patch is not exactly correct.
> @@ -959,9 +959,10 @@ void do_exit(long code) > preempt_count()); > > acct_update_integrals(tsk); > - /* sync mm's RSS info before statistics gathering */ > - if (tsk->mm) > - sync_mm_rss(tsk->mm); > + > + /* Release mm and sync mm's RSS info before statistics gathering */ > + mm_release(tsk, tsk->mm);
This breaks kthread_stop() at least.
The exiting kthread shouldn't do complete_vfork_done() until it sets ->exit_code.
Oleg.
| |