lkml.org 
[lkml]   [2012]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] mm: correctly synchronize rss-counters at exit/exec
    On 04/10, Konstantin Khlebnikov wrote:
    >
    > This patch moves sync_mm_rss() into mm_release(), and moves mm_release() out of
    > do_exit() and calls it earlier. After mm_release() there should be no page-faults.

    Can't prove, but I feel there should be a simpler fix...

    Anyway, this patch is not exactly correct.

    > @@ -959,9 +959,10 @@ void do_exit(long code)
    > preempt_count());
    >
    > acct_update_integrals(tsk);
    > - /* sync mm's RSS info before statistics gathering */
    > - if (tsk->mm)
    > - sync_mm_rss(tsk->mm);
    > +
    > + /* Release mm and sync mm's RSS info before statistics gathering */
    > + mm_release(tsk, tsk->mm);

    This breaks kthread_stop() at least.

    The exiting kthread shouldn't do complete_vfork_done() until it
    sets ->exit_code.

    Oleg.



    \
     
     \ /
      Last update: 2012-04-10 21:13    [W:0.022 / U:30.324 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site