Messages in this thread | | | Date | Tue, 10 Apr 2012 12:17:00 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH v3 1/3] tegra, serial8250: add ->handle_break() uart_port op |
| |
On 04/10/2012 11:36 AM, Dan Williams wrote: > On Tue, Apr 10, 2012 at 8:53 AM, Stephen Warren <swarren@wwwdotorg.org> wrote: >> On 04/09/2012 01:48 PM, Dan Williams wrote: >>> The "KT" serial port has another use case for a "received break" quirk, >>> so before adding another special case to the 8250 core take this >>> opportunity to push such quirks out of the core and into a uart_port op. ... >>> diff --git a/include/linux/of_serial.h b/include/linux/of_serial.h >> ... >>> + * FIXME remove this file when tegra finishes conversion to open firmware, >> >> remove this *prototype* not *file*? > > The entire file should go away since it is only there to export > tegra_serial_handle_break to the deprecated board files. Once this is > open firmware only tegra_serial_handle_break can be marked static, > right?
Ah yes, right.
| |