lkml.org 
[lkml]   [2012]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] virtio_blk: Add help function to format mass of disks
On Tue, Apr 10, 2012 at 08:49:43AM -0700, Tejun Heo wrote:
> Hello, guys.
>
> On Tue, Apr 10, 2012 at 04:34:06PM +0300, Michael S. Tsirkin wrote:
> > > Why not use 'base' below? neither unit nor base change.
> >
> > Yes it's a bit strange, it was the same in Tejun's patch.
> > Tejun, any idea?
>
> It was years ago, so I don't recall much. I think I wanted to use a
> variable name which signifies its role - I worked out the rather
> convoluted base number logic on paper first and I probably wanted to
> keep the distinctions. I don't think it really matters at this point
> tho. Just make sure those functions are marked deprecated so that no
> one else copies them.
>
> Thanks.

I guess I'll keep it same so it's easier to deduplicate
if someon wants to.

> --
> tejun


\
 
 \ /
  Last update: 2012-04-10 17:55    [from the cache]
©2003-2011 Jasper Spaans