lkml.org 
[lkml]   [2012]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] pinctrl: implement pinctrl deferred probing
    On 04/10/2012 02:04 AM, Linus Walleij wrote:
    > From: Linus Walleij <linus.walleij@linaro.org>
    >
    > If drivers try to obtain pinctrl handles for a pin controller that
    > has not yet registered to the subsystem, we need to be able to
    > back out and retry with deferred probing. So let's return
    > -EPROBE_DEFER whenever this location fails.
    >
    > Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
    > Cc: Arnd Bergmann <arnd@arndb.de>
    > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

    This looks fine, except:

    > @@ -521,8 +521,11 @@ static int add_setting(struct pinctrl *p, struct pinctrl_map const *map)
    > dev_err(p->dev, "unknown pinctrl device %s in map entry",
    > map->ctrl_dev_name);

    Perhaps this dev_err (and the one in the other hunk) should be
    downgraded to warn/info/debug?

    > + /*
    > + * OK let us guess that the driver is not there yet, and
    > + * let's defer obtaining this pinctrl handle to later...
    > + */
    > + return -EPROBE_DEFER;
    > }


    \
     
     \ /
      Last update: 2012-04-10 17:39    [W:0.023 / U:29.164 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site