lkml.org 
[lkml]   [2012]   [Apr]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Input: eeti_ts: Mark as CONFIG_BROKEN
    On Sat, Apr 07, 2012 at 01:32:31PM -0700, Olof Johansson wrote:
    > Haojian, I think it was probably premature to do the multiplatform
    > change like that, since it means that a PXA-only kernel has no mapping
    > from irq_to_gpio to pxa_irq_to_gpio. Can you please address this as a
    > fix for 3.4?

    Please fix ezx-pcap instead - it's broken as it currently stands by using
    irq_to_gpio(), and it's one reason why my randconfig builds on OMAP fail.

    The big problem is - what does this do:

    do {
    ...
    } while (gpio_get_value(irq_to_gpio(pcap->spi->irq)));

    if pcap->spi->irq has no GPIO associated with the interrupt? irq_to_gpio()
    probably returns some random number which might be some other GPIO in the
    system, and gpio_get_value() could oops if irq_to_gpio returns a negative
    or large positive number. To put it another way, according to the above
    code, irq_to_gpio() must always return a valid gpio for the IRQ even if
    the IRQ doesn't have a GPIO associated with it.

    This is a fine illustration of why irq_to_gpio() is just plain broken in
    its design.


    \
     
     \ /
      Last update: 2012-04-10 12:13    [W:0.021 / U:31.720 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site