lkml.org 
[lkml]   [2012]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 0/4] tools: Add a toplevel Makefile
    On Sun, Apr 01, 2012 at 10:42:53AM +0200, Ingo Molnar wrote:
    > > Make will try to update the two targets "tools/perf" and "install"
    > > in parallel. And it does not look easy to teach make that when you
    > > specify the target "tools/*" then the install target should just
    > > be ignored and passed down to the sub-make.
    > >
    > > Anything that adds more complexity to the top-level Makefile should
    > > be avoided if at all possible. It is un-maintainable as-is.
    > > And the consistency issue is also important.
    > >
    > > I know that if I do "make install" the kernel will be installed.
    > > So one could argue that the same should apply to
    > > the targets below tools/.
    > > But then this should be for all targets and not just install.
    > > If someone come up with a clean way to do so it is fine.
    > > but the original proposal with "tinstall" just do not cut it.
    >
    > 'tinstall' is definitely out, no argument about that.
    >
    > Viable options are:
    >
    > tools/perf install
    > tools/perf_install
    > tools/perf-install
    >
    > I'm fine with either one.

    What Sam said - it is not that easy and probably cannot be done
    without trickery to tell make that "install" becomes a sub-target when
    "tools/<toolname>" is in front of it.

    OTOH, "perf_install" is easily doable and the "perf-install" one with
    the "-" could be misleading since all make targets have a "_" in their
    names.

    I'll redo the patchset with <toolname>_install targets since this is the
    most straightforward option. In that case, if one wants to build and
    install perf, she simply does

    $ make tools/perf_install

    and the same would work for the rest of the tools in there.

    Thanks.

    --
    Regards/Gruss,
    Boris.

    Advanced Micro Devices GmbH
    Einsteinring 24, 85609 Dornach
    GM: Alberto Bozzo
    Reg: Dornach, Landkreis Muenchen
    HRB Nr. 43632 WEEE Registernr: 129 19551


    \
     
     \ /
      Last update: 2012-04-01 11:25    [W:0.022 / U:60.736 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site