Messages in this thread | | | Date | Mon, 2 Apr 2012 00:39:11 +0200 | Subject | Re: [PATCH/RFC v2] ARM: amba: Remove AMBA level regulator support | From | Linus Walleij <> |
| |
On Sun, Apr 1, 2012 at 9:39 PM, Rabin Vincent <rabin@rab.in> wrote: > On Mon, Apr 2, 2012 at 00:52, Linus Walleij <linus.walleij@linaro.org> wrote: >> Combined with the PL022 patch this causes a power regression since >> the PL022 is hereafter always on. > > How can there be a "power regression" here? This is the only user of > the vcore regulator, and, apart from the fact that its disable routine > only decrements an essentialy write-only variable, it is shared which > several devices which already never disable it.
Yes true... Hm I hope something else in mainline will increase refcount to vape so it's not disabled at regulator_has_full_constraints()? Better test it, then I'll see.
Mark: as Rabin says the v1 patch is probably fine, are you pushing this to ARM SoC or into Russell's patch tracker?
Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |