Messages in this thread | | | Date | Sun, 1 Apr 2012 22:27:50 +0100 | From | Mark Brown <> | Subject | Re: [PATCH/RFC v2] ARM: amba: Remove AMBA level regulator support |
| |
On Sun, Apr 01, 2012 at 09:22:50PM +0200, Linus Walleij wrote:
> Combined with the PL022 patch this causes a power regression since > the PL022 is hereafter always on.
I guess this code isn't in mainline, though? In that case you can always add a revert of this commit to your out of tree patches if you need to.
> But I guess if I fix a power domain patch to accomplish much the > same things then nothing is really lost...
Let me know if you run into any trouble with that - I don't have any systems which could usefully use such support so I'm unlikely to work on it directly and from what you were saying you'll need to integrate with existing power domain code anyway.
> And I do like the change, if for nothing else so for the fact that it > eventually pushes to power domains what belongs there, so:
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Thanks.
> But to the defence: power domain code was not in the kernel > when the AMBA "vcore" regulator was introduced so how else > could we do it... except for inventing power domains...
Which might've happened sooner if we'd noticed :) There were some other platforms doing similar things but they mostly used the clock API since it was always entirely platform code until 3.4 so they're less intrusive into the generic code. [unhandled content-type:application/pgp-signature] | |