Messages in this thread | | | Date | Fri, 09 Mar 2012 18:31:17 +0900 | From | Fernando Luis Vázquez Cao <> | Subject | Re: [PATCH 1/2] boot: ignore early NMIs |
| |
On 03/09/2012 01:35 AM, Eric W. Biederman wrote:
> I am fine with your approach. I suggest a big fat comment mentioning > the 10 byte requirement and the register requirement. > > Neither one is locally obvious which makes it easy to goof when > modifying the code. Done.
>>> Doing something less brittle than: >>>> extern const char early_idt_handlers[NUM_EXCEPTION_VECTORS][10]; >>> in segment.h might be a good idea as well. Tackled that one too.
I will be replying to this email with the updated patches.
Thanks, Fernando
| |