lkml.org 
[lkml]   [2012]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] mm: SLAB Out-of-memory diagnostics
Howdy Eric,

On Fri, Mar 09, 2012 at 04:23:39PM -0800, Eric Dumazet wrote:
> On Fri, 2012-03-09 at 17:27 -0300, Rafael Aquini wrote:
> > Following the example at mm/slub.c, add out-of-memory diagnostics to the
> > SLAB allocator to help on debugging certain OOM conditions.
> >
> > An example print out looks like this:
> >
> > <snip page allocator out-of-memory message>
> > SLAB: Unable to allocate memory on node 0 (gfp=0x11200)
> > cache: bio-0, object size: 192, order: 0
> > node 0: slabs: 3/3, objs: 60/60, free: 0
>
> Should probably be :
>
> node: 0 slabs: 3/3, objs: 60/60, free: 0
>

No it shouldn't. Please refer to https://lkml.org/lkml/2012/3/7/242

The intent here was just to match slub's printout for its slab_out_of_memory
node list slab components, as one can check on mm/slub.c:

2096 printk(KERN_WARNING
2097 " node %d: slabs: %ld, objs: %ld, free: %ld\n",
2098 node, nr_slabs, nr_objs, nr_free);


> > + printk(KERN_WARNING
> > + " node %d: slabs: %ld/%ld, objs: %ld/%ld, free: %ld\n",
>
> Probably should be :
> " node: %d slabs: %ld/%ld, objs: %ld/%ld, free: %ld\n",
>

ditto.


Thanks for your feedback!

Rafael


\
 
 \ /
  Last update: 2012-03-10 04:23    [W:0.060 / U:0.832 seconds]
©2003-2014 Jasper Spaans. Advertise on this site