Messages in this thread Patch in this message | | | Subject | Re: Build broken on s390 and ia64 [was: Linux 2.6.32.58] | From | Ben Hutchings <> | Date | Fri, 09 Mar 2012 05:29:13 +0000 |
| |
On Mon, 2012-03-05 at 23:33 +0100, Willy Tarreau wrote: > Hi, > > On Mon, Mar 05, 2012 at 01:48:24PM +0100, Jiri Slaby wrote: > > >>> Linus Torvalds (2): Fix autofs compile without CONFIG_COMPAT > > >> > > >> But who defines is_compat_task *with* CONFIG_COMPAT on ia64? > > >> > > >> fs/autofs4/inode.c: In function 'autofs4_fill_super': > > >> fs/autofs4/inode.c:345: error: implicit declaration of function > > >> 'is_compat_task' > > > > > > The ia64 compat code got entirely removed, since it was broken: > > > > > > 32974ad4907cdde6c9de612cd1b2ee0568fb9409 "[IA64] Remove COMPAT_IA32 support" > > > > Yes, but that is even in 2.6.34. So the fix for autofs is incomplete in > > .32 as it breaks build on configs which used to work. > > So in the end, does anybody have an idea what is missing from this patch ? > I'm not sure that reverting the autofs fix is a right solution either :-/
Either cherry-pick commit 32974ad4907cdde6c9de612cd1b2ee0568fb9409 or use this reduced version.
Ben.
--- From: Ben Hutchings <ben@decadent.org.uk> Date: Fri, 9 Mar 2012 04:21:03 +0000 Subject: [PATCH] [IA64] Remove COMPAT_IA32 support
commit 32974ad4907cdde6c9de612cd1b2ee0568fb9409 upstream
This just changes Kconfig rather than touching all the other files the original commit did.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk> --- arch/ia64/Kconfig | 17 ----------------- 1 files changed, 0 insertions(+), 17 deletions(-)
diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig index 1ee596c..20fc9c5 100644 --- a/arch/ia64/Kconfig +++ b/arch/ia64/Kconfig @@ -502,23 +502,6 @@ config ARCH_PROC_KCORE_TEXT def_bool y depends on PROC_KCORE -config IA32_SUPPORT - bool "Support for Linux/x86 binaries" - help - IA-64 processors can execute IA-32 (X86) instructions. By - saying Y here, the kernel will include IA-32 system call - emulation support which makes it possible to transparently - run IA-32 Linux binaries on an IA-64 Linux system. - If in doubt, say Y. - -config COMPAT - bool - depends on IA32_SUPPORT - default y - -config COMPAT_FOR_U64_ALIGNMENT - def_bool COMPAT - config IA64_MCA_RECOVERY tristate "MCA recovery from errors other than TLB." -- 1.7.9.1
-- Ben Hutchings Quantity is no substitute for quality, but it's the only one we've got. [unhandled content-type:application/pgp-signature] | |