Messages in this thread |  | | | Subject | Re: [PATCH] x86: use enum instead of literals for trap values | | From | Steven Rostedt <> | | Date | Fri, 09 Mar 2012 13:52:04 -0500 |
| |
On Fri, 2012-03-09 at 19:28 +0100, Borislav Petkov wrote: > On Fri, Mar 09, 2012 at 10:21:52AM -0800, Kees Cook wrote: > > > I have to admit personally to prefer something like X86_XCP_XX where XX > > > is the two-letter code that the Intel documentation uses for that trap, > > > i.e. #GP, #BR, #MC and so on. > > > > We need a single person to decide on this bike shed color. :) If the > > list of enum names can be agreed on, I'll be happy to do the > > search/replace for it. > > Well, > > here are my 2¢: I agree with hpa because > > a) it maps the CPU vendor documentation > b) it is nicely short
I agree too, except where does "XCP" come from? Is it short for "exception"? Doing a search on "XCP Intel" gives me hits on Armari XCP an "XCP server". Perhaps to keep in line with the documentation, should it be:
X86_VEC_XX?
-- Steve
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |