Messages in this thread | | | Date | Fri, 9 Mar 2012 12:41:19 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v6 1/5] Extcon (external connector): import Android's switch class and modify. |
| |
On Mon, Feb 27, 2012 at 09:15:35PM +0900, MyungJoo Ham wrote:
> +#ifdef CONFIG_ANDROID > + extcon_class = class_create(THIS_MODULE, "switch"); > +#else /* !CONFIG_ANDROID */ > + extcon_class = class_create(THIS_MODULE, "extcon"); > +#endif /* CONFIG_ANDROID */
This seems somewhat sad - if ANDROID is turned on the standard ABI vanishes. It'd be much nicer to do this with a symlink (or with symlinks within the android directory if the driver core doesn't support that). That way userspace code can be written to the new ABI and will work on Android systems without ifdefery. [unhandled content-type:application/pgp-signature] | |