lkml.org 
[lkml]   [2012]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [tip:x86/urgent] x86, efi: Delete efi_ioremap() and fix CONFIG_X86_32 oops
    From
    Date
    On Wed, 2012-03-07 at 10:14 -0800, Yinghai Lu wrote:
    > > +
    > > + if (end <= max_low_pfn << PAGE_SHIFT)
    > > + max_low_pfn_mapped = last_pfn_mapped;
    >
    > those two line could be dropped if you have
    > last_pfn_mapped = 1<<(20 - 12);
    > before the loop

    When you say "dropped" do you mean "not executed" or "deleted because
    they are unnecessary"?

    > Also you can not use max_low_pfn here...

    Why not? Please explain.

    > you need to update e820_end_pfn to search max pfn for several types like
    > > + case E820_RAM:
    > > + case E820_RESERVED_EFI:
    > > + case E820_ACPI:
    > > + case E820_NVS:

    Yeah, that's a good point. I'll make that change.

    > but my question is:
    > is there any system that will put EFI runtime, or ACPI or NVS above
    > 4G? is that legal?

    Matthew already answered this. I think it's entirely possible that EFI
    runtime regions can reside above 4G.



    \
     
     \ /
      Last update: 2012-03-09 11:51    [W:0.023 / U:89.772 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site