Messages in this thread Patch in this message | | | Date | Thu, 8 Mar 2012 14:48:55 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: [PATCH] memcg: fix mapcount check in move charge code for anonymous page |
| |
On Fri, 2 Mar 2012 15:35:08 -0500 Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> wrote:
> Currently charge on shared anonyous pages is supposed not to moved > in task migration. To implement this, we need to check that mapcount > 1, > instread of > 2. So this patch fixes it. > > Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Hm. I don't remember why this check uses mapcount > 2...maybe bug.
Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> --- > mm/memcontrol.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git linux-next-20120228.orig/mm/memcontrol.c linux-next-20120228/mm/memcontrol.c > index b6d1bab..785f6d3 100644 > --- linux-next-20120228.orig/mm/memcontrol.c > +++ linux-next-20120228/mm/memcontrol.c > @@ -5102,7 +5102,7 @@ static struct page *mc_handle_present_pte(struct vm_area_struct *vma, > return NULL; > if (PageAnon(page)) { > /* we don't move shared anon */ > - if (!move_anon() || page_mapcount(page) > 2) > + if (!move_anon() || page_mapcount(page) > 1) > return NULL; > } else if (!move_file()) > /* we ignore mapcount for file pages */ > -- > 1.7.7.6 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
| |