lkml.org 
[lkml]   [2012]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 15/17] staging: tidspbridge: remove gh_init() and gh_exit()
    Date
    The gh module has a gh_init() and a gh_exit(), but they don't do
    anything, they are just noops.

    This patch removes these functions.

    There is no functional changes.

    Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
    ---
    drivers/staging/tidspbridge/gen/gh.c | 18 ------------------
    drivers/staging/tidspbridge/include/dspbridge/gh.h | 2 --
    drivers/staging/tidspbridge/pmgr/dbll.c | 12 ++----------
    3 files changed, 2 insertions(+), 30 deletions(-)

    diff --git a/drivers/staging/tidspbridge/gen/gh.c b/drivers/staging/tidspbridge/gen/gh.c
    index 60aa7b0..25eaef7 100644
    --- a/drivers/staging/tidspbridge/gen/gh.c
    +++ b/drivers/staging/tidspbridge/gen/gh.c
    @@ -95,15 +95,6 @@ void gh_delete(struct gh_t_hash_tab *hash_tab)
    }

    /*
    - * ======== gh_exit ========
    - */
    -
    -void gh_exit(void)
    -{
    - /* Do nothing */
    -}
    -
    -/*
    * ======== gh_find ========
    */

    @@ -122,15 +113,6 @@ void *gh_find(struct gh_t_hash_tab *hash_tab, void *key)
    }

    /*
    - * ======== gh_init ========
    - */
    -
    -void gh_init(void)
    -{
    - /* Do nothing */
    -}
    -
    -/*
    * ======== gh_insert ========
    */

    diff --git a/drivers/staging/tidspbridge/include/dspbridge/gh.h b/drivers/staging/tidspbridge/include/dspbridge/gh.h
    index 9de291d..da85079 100644
    --- a/drivers/staging/tidspbridge/include/dspbridge/gh.h
    +++ b/drivers/staging/tidspbridge/include/dspbridge/gh.h
    @@ -23,9 +23,7 @@ extern struct gh_t_hash_tab *gh_create(u16 max_bucket, u16 val_size,
    bool(*match) (void *, void *),
    void (*delete) (void *));
    extern void gh_delete(struct gh_t_hash_tab *hash_tab);
    -extern void gh_exit(void);
    extern void *gh_find(struct gh_t_hash_tab *hash_tab, void *key);
    -extern void gh_init(void);
    extern void *gh_insert(struct gh_t_hash_tab *hash_tab, void *key, void *value);
    #ifdef CONFIG_TIDSPBRIDGE_BACKTRACE
    void gh_iterate(struct gh_t_hash_tab *hash_tab,
    diff --git a/drivers/staging/tidspbridge/pmgr/dbll.c b/drivers/staging/tidspbridge/pmgr/dbll.c
    index 071ee86..9f07036 100644
    --- a/drivers/staging/tidspbridge/pmgr/dbll.c
    +++ b/drivers/staging/tidspbridge/pmgr/dbll.c
    @@ -187,8 +187,6 @@ static u16 name_hash(void *key, u16 max_bucket);
    static bool name_match(void *key, void *sp);
    static void sym_delete(void *value);

    -static u32 refs; /* module reference count */
    -
    /* Symbol Redefinition */
    static int redefined_symbol;
    static int gbl_search = 1;
    @@ -268,10 +266,7 @@ void dbll_delete(struct dbll_tar_obj *target)
    */
    void dbll_exit(void)
    {
    - refs--;
    -
    - if (refs == 0)
    - gh_exit();
    + /* do nothing */
    }

    /*
    @@ -394,10 +389,7 @@ int dbll_get_sect(struct dbll_library_obj *lib, char *name, u32 *paddr,
    */
    bool dbll_init(void)
    {
    - if (refs == 0)
    - gh_init();
    -
    - refs++;
    + /* do nothing */

    return true;
    }
    --
    1.7.9.1
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-03-09 01:09    [W:0.025 / U:0.388 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site