lkml.org 
[lkml]   [2012]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 12/17] staging: tidspbridge: remove dmm_init() and dmm_exit()
    Date
    The dmm module has a dmm_init() and a dmm_exit() whose only purpose is
    to keep a reference counting which is not used at all.

    This patch removes these functions and the reference count variable.

    There is no functional changes.

    Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
    ---
    .../staging/tidspbridge/include/dspbridge/dmm.h | 4 --
    drivers/staging/tidspbridge/pmgr/dev.c | 6 ----
    drivers/staging/tidspbridge/pmgr/dmm.c | 32 --------------------
    3 files changed, 0 insertions(+), 42 deletions(-)

    diff --git a/drivers/staging/tidspbridge/include/dspbridge/dmm.h b/drivers/staging/tidspbridge/include/dspbridge/dmm.h
    index 6c58335..c3487be 100644
    --- a/drivers/staging/tidspbridge/include/dspbridge/dmm.h
    +++ b/drivers/staging/tidspbridge/include/dspbridge/dmm.h
    @@ -61,10 +61,6 @@ extern int dmm_create(struct dmm_object **dmm_manager,
    struct dev_object *hdev_obj,
    const struct dmm_mgrattrs *mgr_attrts);

    -extern bool dmm_init(void);
    -
    -extern void dmm_exit(void);
    -
    extern int dmm_create_tables(struct dmm_object *dmm_mgr,
    u32 addr, u32 size);

    diff --git a/drivers/staging/tidspbridge/pmgr/dev.c b/drivers/staging/tidspbridge/pmgr/dev.c
    index 734d47e..c5e627c 100644
    --- a/drivers/staging/tidspbridge/pmgr/dev.c
    +++ b/drivers/staging/tidspbridge/pmgr/dev.c
    @@ -657,9 +657,6 @@ int dev_get_bridge_context(struct dev_object *hdev_obj,
    void dev_exit(void)
    {
    refs--;
    -
    - if (refs == 0)
    - dmm_exit();
    }

    /*
    @@ -671,9 +668,6 @@ bool dev_init(void)
    {
    bool ret = true;

    - if (refs == 0)
    - dmm_init();
    -
    if (ret)
    refs++;

    diff --git a/drivers/staging/tidspbridge/pmgr/dmm.c b/drivers/staging/tidspbridge/pmgr/dmm.c
    index 83faff8..7c9f839 100644
    --- a/drivers/staging/tidspbridge/pmgr/dmm.c
    +++ b/drivers/staging/tidspbridge/pmgr/dmm.c
    @@ -51,8 +51,6 @@ struct dmm_object {
    spinlock_t dmm_lock; /* Lock to access dmm mgr */
    };

    -/* ----------------------------------- Globals */
    -static u32 refs; /* module reference count */
    struct map_page {
    u32 region_size:15;
    u32 mapped_size:15;
    @@ -172,18 +170,6 @@ int dmm_delete_tables(struct dmm_object *dmm_mgr)
    }

    /*
    - * ======== dmm_exit ========
    - * Purpose:
    - * Discontinue usage of module; free resources when reference count
    - * reaches 0.
    - */
    -void dmm_exit(void)
    -{
    -
    - refs--;
    -}
    -
    -/*
    * ======== dmm_get_handle ========
    * Purpose:
    * Return the dynamic memory manager object for this device.
    @@ -206,24 +192,6 @@ int dmm_get_handle(void *hprocessor, struct dmm_object **dmm_manager)
    }

    /*
    - * ======== dmm_init ========
    - * Purpose:
    - * Initializes private state of DMM module.
    - */
    -bool dmm_init(void)
    -{
    - bool ret = true;
    -
    - if (ret)
    - refs++;
    -
    - virtual_mapping_table = NULL;
    - table_size = 0;
    -
    - return ret;
    -}
    -
    -/*
    * ======== dmm_map_memory ========
    * Purpose:
    * Add a mapping block to the reserved chunk. DMM assumes that this block
    --
    1.7.9.1
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-03-09 01:09    [W:0.024 / U:64.468 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site