lkml.org 
[lkml]   [2012]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 16/17] staging: tidspbridge: remove ref counting in nldr.c
    Date
    The nldr module has a nldr_init() and a nldr_exit() whose only purpose
    is to keep a reference counting which is not used at all.

    This patch only removes the reference count variable, but not the
    functions, because they are used through an interface.

    There is no functional changes.

    Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez@igalia.com>
    ---
    drivers/staging/tidspbridge/rmgr/nldr.c | 7 ++-----
    1 files changed, 2 insertions(+), 5 deletions(-)

    diff --git a/drivers/staging/tidspbridge/rmgr/nldr.c b/drivers/staging/tidspbridge/rmgr/nldr.c
    index a9d7a32..46086b5 100644
    --- a/drivers/staging/tidspbridge/rmgr/nldr.c
    +++ b/drivers/staging/tidspbridge/rmgr/nldr.c
    @@ -263,8 +263,6 @@ static struct dbll_fxns ldr_fxns = {
    (dbll_unload_fxn) dbll_unload,
    };

    -static u32 refs; /* module reference count */
    -
    static int add_ovly_info(void *handle, struct dbll_sect_info *sect_info,
    u32 addr, u32 bytes);
    static int add_ovly_node(struct dsp_uuid *uuid_obj,
    @@ -627,7 +625,7 @@ void nldr_delete(struct nldr_object *nldr_obj)
    */
    void nldr_exit(void)
    {
    - refs--;
    + /* do nothing */
    }

    /*
    @@ -743,8 +741,7 @@ int nldr_get_rmm_manager(struct nldr_object *nldr,
    */
    bool nldr_init(void)
    {
    - refs++;
    -
    + /* do nothing */
    return true;
    }

    --
    1.7.9.1
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-03-09 01:07    [W:3.631 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site