Messages in this thread | | | From | Roland McGrath <> | Subject | Re: [PATCH 2/2 v2] core dump: add VM_NODUMP, MADV_NODUMP, MADV_CLEAR_NODUMP | Date | Thu, 8 Mar 2012 13:44:17 -0800 (PST) |
| |
I'm vaguely dubious about the desireability of using this new feature. (I would hate to try to debug a qemu bug from a dump where half the interesting state was intentionally hidden from me.) But I don't see any problem with the implementation.
As to the interface, I think the bits are OK but it would be more in keeping with the existing MADV_* names to call the new values MADV_DONTDUMP and MADV_DODUMP.
Thanks, Roland
| |