Messages in this thread |  | | | From | (Eric W. Biederman) | | Date | Thu, 08 Mar 2012 13:43:09 -0800 | | Subject | Re: [PATCH] Fix memory leak in sysfs_sd_setsecdata(). |
| |
Greg KH <gregkh@linuxfoundation.org> writes:
> On Thu, Mar 08, 2012 at 01:02:20PM -0800, Eric W. Biederman wrote: >> Masami Ichikawa <masami256@gmail.com> writes: >> >> > This patch fixies follwing two memory leak patterns that reported by kmemleak. >> > sysfs_sd_setsecdata() is called during sys_lsetxattr() operation. >> > It checks sd->s_iattr is NULL or not. Then if it is NULL, it calls >> > sysfs_init_inode_attrs() to allocate memory. >> > That code is this. >> >> I don't know how you count two memory leaks. But there is definitely a >> leak here sd->s_iattr is allocated and then never assigned. It looks >> like I introduced that leak when I re-factored the code to protect >> the code with sysfs_mutex at the end of 2009. >> >> I am surprise the securlity label crowd has not been screaming about >> selinux protection not working on sysfs for the last two years. >> >> I have reviewed the code and the fix looks obvious and correct. >> >> Greg can you pick this up? > > I applied it a while ago to my tree already :)
Odd I didn't see it linux-next when I looked an hour or so ago.
As long as it is there and it makes it to stable.
Eric
|  |