[lkml]   [2012]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 6/6] vt: push the tty_lock down into the map handling
    On Fri, Mar 02, 2012 at 03:00:14PM +0000, Alan Cox wrote:
    > From: Alan Cox <>
    > When we do this it becomes clear the lock we should be holding is the vc
    > lock, and in fact many of our other helpers are properly invoked this way.
    > We don't at this point guarantee not to race the keyboard code but the results
    > of that appear harmless and that was true before we started as well.
    > We now have no users of tty_lock in the console driver...
    > Signed-off-by: Alan Cox <>
    > ---
    > drivers/tty/vt/consolemap.c | 119 ++++++++++++++++++++++++++++++++-----------
    > drivers/tty/vt/vt_ioctl.c | 25 ++-------
    > include/linux/vt_kern.h | 1
    > 3 files changed, 93 insertions(+), 52 deletions(-)

    With this patch applied, I get the following build error:

    drivers/tty/vt/consolemap.c: In function ‘con_set_trans_old’:
    drivers/tty/vt/consolemap.c:315:2: error: implicit declaration of function ‘console_lock’ [-Werror=implicit-function-declaration]
    drivers/tty/vt/consolemap.c:323:2: error: implicit declaration of function ‘console_unlock’ [-Werror=implicit-function-declaration]

    what went wrong?

    I've applied the first 5 in this series to my tree now, but not this


    greg k-h
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2012-03-08 20:17    [W:0.020 / U:21.340 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site