lkml.org 
[lkml]   [2012]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RESEND][PATCH 2/2 v3] deal with guest panicked event
    On Thu, Mar 08, 2012 at 01:28:56PM +0200, Avi Kivity wrote:
    > On 03/08/2012 12:15 PM, Wen Congyang wrote:
    > > When the host knows the guest is panicked, it will set
    > > exit_reason to KVM_EXIT_GUEST_PANICKED. So if qemu receive
    > > this exit_reason, we can send a event to tell management
    > > application that the guest is panicked and set the guest
    > > status to RUN_STATE_PANICKED.
    > >
    > > Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
    > > ---
    > > kvm-all.c | 5 +++++
    > > monitor.c | 3 +++
    > > monitor.h | 1 +
    > > qapi-schema.json | 2 +-
    > > qmp.c | 3 ++-
    > > vl.c | 1 +
    > > 6 files changed, 13 insertions(+), 2 deletions(-)
    > >
    > > diff --git a/kvm-all.c b/kvm-all.c
    > > index 77eadf6..b3c9a83 100644
    > > --- a/kvm-all.c
    > > +++ b/kvm-all.c
    > > @@ -1290,6 +1290,11 @@ int kvm_cpu_exec(CPUState *env)
    > > (uint64_t)run->hw.hardware_exit_reason);
    > > ret = -1;
    > > break;
    > > + case KVM_EXIT_GUEST_PANICKED:
    > > + monitor_protocol_event(QEVENT_GUEST_PANICKED, NULL);
    > > + vm_stop(RUN_STATE_PANICKED);
    > > + ret = -1;
    > > + break;
    > >
    >
    > If the management application is not aware of this event, then it will
    > never resume the guest, so it will appear hung.

    Even if the mgmt app doesn't know about the QEVENT_GUEST_PANICKED, it should
    still see a QEVENT_STOP event emitted by vm_stop() surely ? So it will
    know the guest CPUs have been stopped, even if it isn't aware of the
    reason why, which seems fine to me.

    Daniel
    --
    |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
    |: http://libvirt.org -o- http://virt-manager.org :|
    |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
    |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|


    \
     
     \ /
      Last update: 2012-03-08 12:39    [W:0.040 / U:60.468 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site