lkml.org 
[lkml]   [2012]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: Build broken on s390 and ia64 [was: Linux 2.6.32.58]
    On 03/05/2012 11:33 PM, Willy Tarreau wrote:
    > Hi,
    >
    > On Mon, Mar 05, 2012 at 01:48:24PM +0100, Jiri Slaby wrote:
    >>>>> Linus Torvalds (2): Fix autofs compile without CONFIG_COMPAT
    >>>>
    >>>> But who defines is_compat_task *with* CONFIG_COMPAT on ia64?
    >>>>
    >>>> fs/autofs4/inode.c: In function 'autofs4_fill_super':
    >>>> fs/autofs4/inode.c:345: error: implicit declaration of function
    >>>> 'is_compat_task'
    >>>
    >>> The ia64 compat code got entirely removed, since it was broken:
    >>>
    >>> 32974ad4907cdde6c9de612cd1b2ee0568fb9409 "[IA64] Remove COMPAT_IA32 support"
    >>
    >> Yes, but that is even in 2.6.34. So the fix for autofs is incomplete in
    >> .32 as it breaks build on configs which used to work.
    >
    > So in the end, does anybody have an idea what is missing from this patch ?
    > I'm not sure that reverting the autofs fix is a right solution either :-/

    Nobody relevant? Hmm... I use the attached patch. If there are no
    objections, I will add a header there and send to Willy.

    thanks,
    --
    js
    suse labs
    ---
    arch/ia64/include/asm/compat.h | 5 +++++
    1 file changed, 5 insertions(+)

    --- a/arch/ia64/include/asm/compat.h
    +++ b/arch/ia64/include/asm/compat.h
    @@ -204,4 +204,9 @@ arch_compat_alloc_user_space (long len)
    return (void __user *) (((regs->r12 & 0xffffffff) & -16) - len);
    }

    +/* for !COMPAT this is defined in linux/compat.h */
    +#ifdef CONFIG_COMPAT
    +#define is_compat_task() (0)
    +#endif
    +
    #endif /* _ASM_IA64_COMPAT_H */
    \
     
     \ /
      Last update: 2012-03-08 12:09    [W:0.027 / U:30.424 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site