lkml.org 
[lkml]   [2012]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v6] sound/soc/codecs: add LAPIS Semiconductor ML26124
    From
    On Wed, Mar 7, 2012 at 8:48 PM, Mark Brown
    <broonie@opensource.wolfsonmicro.com> wrote:
    >> If possible, I want to use framework features. However, I judged it is
    >> not possible.
    >> Let me confirm again.
    >> As I said before, all ML26124 registers need to be accessed by
    >> different address when read and write.
    >> Like below
    >> R       W
    >> $00h $01h Sampling setting
    >> $02h $03h PLL setting
    >> ...
    >> Even so, can I use framework features ?
    > No, in which case (to repeat what I said previously) you need to make
    > the code *much* clearer so the reader can understand what it is doing
    > and why it's having to open code this stuff.

    I understand you agree to use ml26124_update_bits(), right ?
    If so, do you mean that I should just add explanation (like as I
    explained before)
    why the function() is necessary to above prototype of ml26124_update_bits() ?

    thanks.
    --
    ROHM Co., Ltd.
    tomoya
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-03-08 03:27    [W:0.023 / U:31.704 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site