lkml.org 
[lkml]   [2012]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 2/2] perf: Add a new sort order: SORT_INCLUSIVE

Further testing showed one more bad memory reference when using
sort inclusive. Fixed by the patch below.

commit 799f80b6e8168d4813de094f2327367d6d226a8c
Author: Arun Sharma <asharma@fb.com>
Date: Wed Mar 7 15:05:00 2012 -0800

perf: fix some bad memory references in tui

Check for he->ms.sym since that's what we're dereferencing

Signed-off-by: Arun Sharma <asharma@fb.com>

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index b9d0fb2..d4e0ec5 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -86,7 +86,7 @@ static int perf_evsel__add_hist_entry(struct perf_evsel *evsel,
* so we don't allocated the extra space needed because the stdio
* code will not use it.
*/
- if (al->sym != NULL && use_browser > 0) {
+ if (he->ms.sym != NULL && use_browser > 0) {
struct annotation *notes = symbol__annotation(he->ms.sym);

assert(evsel != NULL);

\
 
 \ /
  Last update: 2012-03-08 00:17    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site