lkml.org 
[lkml]   [2012]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/3] Kbuild: Implement CONFIG_UIMAGE_KERNEL_NOLOAD
    On 03/06/2012 11:52 PM, Guan Xuetao wrote:
    > On Tue, 2012-03-06 at 17:30 -0700, Stephen Warren wrote:
    >> This allows the user to use U-Boot's mkimage's -T kernel_noload option
    >> if their arch Kconfig allows it, and they desire.
    ...
    > Hi, Stephen,
    > It seems that UIMAGE_ARCH and UIMAGE_LOADADDR can't be modified from
    > arch-Makefiles.

    Oh dear, you're right. I suck at testing:-( I've fixed this locally.

    For reference, Makefile.lib is included after the Makefile in the
    relevant source directory, whereas my patch assumed the other way
    around. So, rather than setting defaults in Makefile.lib and having
    foo/Makefile override them, I should set the non-defaults in
    foo/Makefile, and have Makefile.lib provide default values for variables
    that aren't already set. Testing indicates this solves the problem!


    \
     
     \ /
      Last update: 2012-03-07 19:13    [W:0.035 / U:0.068 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site