[lkml]   [2012]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] [SCSI] sd: set BIO_MAPPED_INTEGRITY bit correctly in sd_dif_prepare().
    On Wed, Mar 07, 2012 at 08:11:35PM +0530, santosh nayak wrote:
    > - bio->bi_flags |= BIO_MAPPED_INTEGRITY;
    > + set_bit(BIO_MAPPED_INTEGRITY, &bio->bi_flags);

    This uses an atomic operation; you should rather use __set_bit instead.

    Matthew Wilcox Intel Open Source Technology Centre
    "Bill, look, we understand that you're interested in selling us this
    operating system, but compare it to ours. We can't possibly take such
    a retrograde step."

     \ /
      Last update: 2012-03-07 16:47    [W:0.024 / U:12.644 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site