Messages in this thread |  | | | Subject | Re: [PATCH] [SCSI] pm8001: fix endian issue with code optimization. | | From | Mark Salyzyn <> | | Date | Wed, 7 Mar 2012 09:58:44 -0500 |
| |
NAK on one point.
The fw_flash_Update_resp structure erroneously defines tag as a dma_addr_t, when in fact it should be an __le32, as the response hTag is reported in this field. The removal of the le32_to_cpu(ppayload->tag) was done to remove a warning, but is incorrect. The warning should have been solved by correctly defining the tag element in the structure.
Sincerely -- Mark Salyzyn
On Feb 26, 2012, at 11:51 PM, Jack Wang wrote:
> Thanks for fix. > Acked-by: Jack Wang <jack_wang@usish.com> >> >> From: Santosh Nayak <santoshprasadnayak@gmail.com> >> >> 1. Fix endian issue. >> 2. Fix the following warning : >> " drivers/scsi/pm8001/pm8001_hwi.c:2932:32: warning: comparison >> between 'enum sas_device_type' and 'enum sas_dev_type'". >> 3. Few code optimization. >> >> Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com> >> --- >> . . . >> @@ -3149,7 +3152,7 @@ mpi_fw_flash_update_resp(struct pm8001_hba_info >> *pm8001_ha, void *piomb) >> struct fw_control_ex fw_control_context; >> struct fw_flash_Update_resp *ppayload >> (struct fw_flash_Update_resp *)(piomb + 4); >> - u32 tag = le32_to_cpu(ppayload->tag); >> + u32 tag = ppayload->tag; >> struct pm8001_ccb_info *ccb = &pm8001_ha->ccb_info[tag]; >> status = le32_to_cpu(ppayload->status); >> memcpy(&fw_control_context,
|  |