Messages in this thread | | | Date | Wed, 07 Mar 2012 09:13:55 -0300 | From | Mauro Carvalho Chehab <> | Subject | Re: [PATCHv7] EDAC core changes in order to properly report errors from all types of memory controllers |
| |
Em 07-03-2012 09:06, Borislav Petkov escreveu: > On Wed, Mar 07, 2012 at 08:36:12AM -0300, Mauro Carvalho Chehab wrote: >>>> - 1 patch that adds a trace event to report memory errors: >>>> events/hw_event: Create a Hardware Events Report Mecanism (HERM) >>> >>> NACK to that last one. >> >> Hmm... interesting... this one adds a tracepoint for non-MCA based memory errors... >> I've understood that you've against only the mca one... > > If you mean the patch at > > http://git.kernel.org/?p=linux/kernel/git/mchehab/linux-edac.git;a=commitdiff;h=56efd647f5a63497a07caaa22e993307aaf95270
Yes, that one.
> where you've removed the trace.*mce call, then I don't object to it per > se. Send it for proper review too, though, because it contains incorrect > comments like > > + * Those events are generated when hardware detected a corrected or > + * uncorrected event, and are meant to replace the current API to report > + * errors defined on both EDAC and MCE subsystems. > > which clearly need fixing.
True. Ok, sent it. > > Thanks. >
Thanks, Mauro
| |