[lkml]   [2012]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRE: [PATCH] regulator: Rename s5m8767_convert_voltage to s5m8767_get_proper_voltage_sel

    > > I was confused by the function name, s5m8767_convert_voltage() converts
    > what to what?
    Convert means that Normal Voltage unit to 8767 internal voltage register
    > BTW, I'm also confused by s5m8767_set_high and s5m8767_set_low functions.
    > Both function sets the same gpios to the same state. ( by different order
    > Maybe we need comments (or rename) for both functions.
    S5M8767A can be controlled with 3 GPIO.
    To control voltage with GPIO, Order is very important.
    Because Voltage inversion should not be happened.
    If DVFS table is like a below,
    1.5Ghz 1.5V
    1.0Ghz 1.0V
    0.5Ghz 0.5V

    If System try to change 1.0Ghz(1.0V) -> 1.5Ghz(1.5V)
    Absolutely 0.5V should not be set.


     \ /
      Last update: 2012-03-07 05:35    [W:0.021 / U:2.712 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site