lkml.org 
[lkml]   [2012]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCHv2 3/3] misc: rename bmp085 to bmp18x
Date
On Tuesday 06 March 2012, Eric Andersson wrote:
> The bmp085 chip has been deprecated by the newer bmp18x chip family from
> Bosch Sensortec.
>
> Reviewed-by: Stefan Nilsson <stefan.nilsson@unixphere.com>
> Signed-off-by: Eric Andersson <eric.andersson@unixphere.com>
> ---
> drivers/misc/Kconfig | 18 +-
> drivers/misc/Makefile | 6 +-
> drivers/misc/bmp085.c | 514 --------------------------------------------
> drivers/misc/bmp18x-i2c.c | 132 +++++++++++
> drivers/misc/bmp18x-spi.c | 140 ++++++++++++
> drivers/misc/bmp18x.c | 512 +++++++++++++++++++++++++++++++++++++++++++
> include/linux/i2c/bmp085.h | 63 ------
> include/linux/i2c/bmp18x.h | 63 ++++++
> 8 files changed, 859 insertions(+), 589 deletions(-)

Please use 'git format-patch -M' when sending a rename patch, to make it obvious
that there are no code changes in the rename. It's a bit suspicous that
the files are different size and that you remove one .c file but add three
other ones.

You should also try give a better explanation why the rename is actually a
good idea. Simply listing the old model as deprecated does not sound like
a strong enough reason, given that some people might rely on the existing
name in user space interfaces.

Arnd


\
 
 \ /
  Last update: 2012-03-06 22:17    [W:0.071 / U:8.832 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site