lkml.org 
[lkml]   [2012]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH bisected regression] sched: rebuild sched domains at suspend/resume
From
Date
On Wed, 2012-03-07 at 00:45 +0400, Konstantin Khlebnikov wrote:
> This is fix for suspend/resume regression introduced in commit 8f2f748b0656
> ("CPU hotplug, cpusets, suspend: Don't touch cpusets during suspend/resume")
> Without this patch suspend always hangs on my thinkpad x220 (2 x CPU * HT).
>
> cpuset_update_active_cpus() not only juggles with bits in cpusets,
> it also calls sched-domains rebuilding after all.
>
> This patch restores sched-domain rebuilds, as it was before that commit.

This changelog also completely fails to explain what the problem was and
how this patch sorts it without re-introducing the problems 8f2f748b0656
was supposed to fix.

I'd rather revert the 'fix' and think about this more (its been broken
pretty much forever anyway) than tinker on top like this.


\
 
 \ /
  Last update: 2012-03-06 22:05    [W:0.128 / U:6.792 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site