lkml.org 
[lkml]   [2012]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 4/4] hpet: factor timer allocate from open
On Tue, 06 Mar 2012 16:04:21 +0100
Clemens Ladisch <clemens@ladisch.de> wrote:

> Thomas Gleixner wrote:
> > On Mon, 5 Mar 2012, akpm@linux-foundation.org wrote:
> >> From: Magnus Lynch <maglyx@gmail.com>
> >> Subject: hpet: factor timer allocate from open
> >>
> >> The current implementation of the /dev/hpet driver couples opening the
> >> device with allocating one of the (scarce) timers (aka comparators). This
> >> is a limitation in that the main counter may be valuable to applications
> >> seeking a high-resolution timer who have no use for the interrupt
> >> generating functionality of the comparators.
> >>
> >> This patch alters the open semantics so that when the device is opened, no
> >> timer is allocated. Operations that depend on a timer being in context
> >> implicitly attempt allocating a timer, to maintain backward compatibility.
> >
> > AFAICT, there is only fasync which calls hpet_alloc_timer(). All other
> > functions are broken by this chage.
>
> Indeed. There was another call in hpet_ioctl_common(), but it appears
> that one somehow got dropped.
>
> Magnus, is this the patch that you submitted and have tested?

I've been carrying this patch since March 2010 - perhaps it rotted.


\
 
 \ /
  Last update: 2012-03-06 19:41    [W:0.033 / U:15.824 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site