lkml.org 
[lkml]   [2012]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] powerpc/srio: Fix the compile errors when building with 64bit
From
Date

On Mar 5, 2012, at 8:20 AM, Liu Gang wrote:

> Hi, Kumar,
>
> On Fri, 2012-03-02 at 09:11 -0600, Kumar Gala wrote:
>>> diff --git a/arch/powerpc/sysdev/fsl_rmu.c b/arch/powerpc/sysdev/fsl_rmu.c
>>> index 1548578..468011e 100644
>>> --- a/arch/powerpc/sysdev/fsl_rmu.c
>>> +++ b/arch/powerpc/sysdev/fsl_rmu.c
>>> @@ -311,8 +311,8 @@ fsl_rio_dbell_handler(int irq, void *dev_instance)
>>>
>>> /* XXX Need to check/dispatch until queue empty */
>>> if (dsr & DOORBELL_DSR_DIQI) {
>>> - u32 dmsg =
>>> - (u32) fsl_dbell->dbell_ring.virt +
>>> + unsigned long dmsg =
>>> + (unsigned long) fsl_dbell->dbell_ring.virt +
>>> (in_be32(&fsl_dbell->dbell_regs->dqdpar) & 0xfff);

How about a struct instead:

struct rmu_dmsg {
u16 dummy;
u16 tid;
u16 sid;
u16 info;
};
struct rmu_dmsg *dmsg = fsl_dbell->dbell_ring.virt + (in_be32(&fsl_dbell->dbell_regs->dqdpar) & 0xfff);

Than you can git rid of the DBELL_* macros.


- k



\
 
 \ /
  Last update: 2012-03-06 18:49    [W:0.105 / U:0.208 seconds]
©2003-2014 Jasper Spaans. Advertise on this site