lkml.org 
[lkml]   [2012]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH 5/6] implement per-cpu&per-domain state machine call_srcu()
From
Date
On Tue, 2012-03-06 at 23:26 +0800, Lai Jiangshan wrote:
> On Tue, Mar 6, 2012 at 7:16 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> > On Tue, 2012-03-06 at 17:57 +0800, Lai Jiangshan wrote:
> >> srcu_head is bigger, it is worth, it provides more ability and simplify
> >> the srcu code.
> >
> > Dubious claim.. memory footprint of various data structures is deemed
> > important. rcu_head is 16 bytes, srcu_head is 32 bytes. I think it would
> > be real nice not to have two different callback structures and not grow
> > them as large.
>
> Also "Dubious" "simplify"?

Nah, I meant dubious.

> bigger struct makes we can store ->check_seq in the callback, makes
> the processing simply.
>
> bigger struct is not required here, we can use a little complex way(batches)
> to do it.

Right, just keep a callback list for each state, and once you fall off
the end process it. No need to keep per callback state.


\
 
 \ /
  Last update: 2012-03-06 16:41    [W:0.139 / U:3.676 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site