lkml.org 
[lkml]   [2012]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 9/9] nfs: don't open in ->d_revalidate
Date
On Tue, 2012-03-06 at 13:56 +0100, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@suse.cz>
>
> NFSv4 can't do reliable opens in d_revalidate, since it cannot know whether a
> mount needs to be followed or not. It does check d_mountpoint() on the dentry,
> which can result in a weird error if the VFS found that the mount does not in
> fact need to be followed, e.g.:
>
> # mount --bind /mnt/nfs /mnt/nfs-clone
> # echo something > /mnt/nfs/tmp/bar
> # echo x > /tmp/file
> # mount --bind /tmp/file /mnt/nfs-clone/tmp/bar
> # cat /mnt/nfs/tmp/bar
> cat: /mnt/nfs/tmp/bar: Not a directory
>
> Which should, by any sane filesystem, result in "something" being printed.
>
> So instead do the open in f_op->open() and in the unlikely case that the cached
> dentry turned out to be invalid, drop the dentry and return ESTALE to let the
> VFS retry.

This patch would force a complete new walk of the path in cases where
today we just do a single lookup of the last component. It really
doesn't seem worth taking that penalty just in order to make some insane
bind mount corner cases work.

--
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@netapp.com
www.netapp.com

\
 
 \ /
  Last update: 2012-03-06 15:15    [W:0.077 / U:7.072 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site