lkml.org 
[lkml]   [2012]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v5 2/2] mmc: core: Support packed command for eMMC4.5 device
    From
    > Hi. Merez.
    >
    > Thanks a lot about your performance measurement.
    >
    > I think that your measurement is enough and correct and the firmware
    > of mmc vender should be optimized or change properly rather than
    > modifying the current patch.
    >
    > And currently we can use only write packed cmd by my suggestion.
    >
    > I would like to add my reviewd-by tag in updated patches also.
    >
    > Reviewed-by: Namjae Jeon <linkinjeon@gmail.com>
    >
    > Thanks.

    I tend to disagree. Adding a massive amount of code that would be disabled
    can be risky. In case this code will not be in use it will not be properly
    tested and its reliability will be uncertain.

    Thanks,
    Maya Erez
    Consultant for Qualcomm Innovation Center, Inc.
    Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum




    \
     
     \ /
      Last update: 2012-03-06 15:13    [W:0.022 / U:153.452 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site