lkml.org 
[lkml]   [2012]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[RFC PATCH] checkpatch: Warn on use of yield()
    From
    Date
    Use of yield() is deprecated or at least generally undesirable.

    Add a checkpatch warning when it's used.
    Suggest cpu_relax instead.

    Signed-off-by: Joe Perches <joe@perches.com>
    ---
    > Joe, can we please have a checkpatch rule?

    Something like this?

    scripts/checkpatch.pl | 5 +++++
    1 files changed, 5 insertions(+), 0 deletions(-)

    diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
    index e32ea7f..80ad474 100755
    --- a/scripts/checkpatch.pl
    +++ b/scripts/checkpatch.pl
    @@ -3300,6 +3300,11 @@ sub process {
    "__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr);
    }

    +# check for use of yield()
    + if ($line =~ /\byield\s*\(\s*\)/ {
    + WARN("YIELD",
    + "yield() is deprecated, consider cpu_relax()\n" . $herecurr);
    + }
    # check for semaphores initialized locked
    if ($line =~ /^.\s*sema_init.+,\W?0\W?\)/) {
    WARN("CONSIDER_COMPLETION",



    \
     
     \ /
      Last update: 2012-03-06 03:03    [W:0.021 / U:91.440 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site