Messages in this thread | | | Date | Mon, 05 Mar 2012 16:51:05 -0500 (EST) | Subject | Re: [PATCH 1/3] qla3xxx: ethernet: Fix bogus interrupt state flag. | From | David Miller <> |
| |
From: santosh nayak <santoshprasadnayak@gmail.com> Date: Fri, 2 Mar 2012 20:39:05 +0530
> From: Santosh Nayak <santoshprasadnayak@gmail.com> > > In 'ql_adapter_initialize' > the first call for 'spin_unlock_irqrestore()' is with hw_flags = 0, > which is as good as 'spin_unlock_irq()' (unconditional interrupt > enabling). If this is intended, then for better performance > 'spin_unlock_irqrestore()' can be replaced with 'spin_unlock_irq()' > and 'spin_lock_irqsave()' can be replaced by 'spin_lock_irq() > > Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
This change is definitely correct, applied, thanks.
| |