Messages in this thread Patch in this message | | | Date | Mon, 5 Mar 2012 00:37:15 -0800 | From | tip-bot for David Ahern <> | Subject | [tip:perf/core] perf record: No build id option fails |
| |
Commit-ID: 6e557a6adfdbb511dbfa7a0a4aa2148f76a01c6d Gitweb: http://git.kernel.org/tip/6e557a6adfdbb511dbfa7a0a4aa2148f76a01c6d Author: David Ahern <dsahern@gmail.com> AuthorDate: Mon, 6 Feb 2012 15:27:52 -0700 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Sat, 3 Mar 2012 11:02:16 -0300
perf record: No build id option fails
A recent refactoring of perf-record introduced the following:
perf record -a -B Couldn't generating buildids. Use --no-buildid to profile anyway. sleep: Terminated
I believe the triple negative was meant to be only a double negative. :-) While I'm there, fixed the grammar on the error message.
Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Robert Richter <robert.richter@amd.com> Cc: Thomas Gleixner <tglx@linutronix.de> Link: http://lkml.kernel.org/r/1328567272-13190-1-git-send-email-dsahern@gmail.com Signed-off-by: David Ahern <dsahern@gmail.com> Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/builtin-record.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c index 0abfb18..39b6a40 100644 --- a/tools/perf/builtin-record.c +++ b/tools/perf/builtin-record.c @@ -503,9 +503,9 @@ static int __cmd_record(struct perf_record *rec, int argc, const char **argv) return err; } - if (!!rec->no_buildid + if (!rec->no_buildid && !perf_header__has_feat(&session->header, HEADER_BUILD_ID)) { - pr_err("Couldn't generating buildids. " + pr_err("Couldn't generate buildids. " "Use --no-buildid to profile anyway.\n"); return -1; }
| |