lkml.org 
[lkml]   [2012]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch v2] x86, efi: fix pointer math issue in handle_ramdisks()
On 03/05/2012 10:42 AM, walter harms wrote:
>
>
> Am 05.03.2012 19:06, schrieb Dan Carpenter:
>> "filename" is a efi_char16_t string so this check for reaching the end
>> of the array doesn't work. We need to cast the pointer to (u8 *) before
>> doing the math.
>>
>> This patch changes the "filename" to "filename_16" to avoid confusion in
>> the future.
>>
>
> maybe it is a bit late, but ...
> is efi_char16_t a generic requirement for EFI ? perhaps we can use wchar_t
> since it is intended for such cases. additional we would get an api for free.
>

wchar_t is typically 32 bits on Linux. 16-bit anything is a major fail
since Unicode doesn't actually fit in 16 bits.

-hpa



\
 
 \ /
  Last update: 2012-03-05 20:37    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site