lkml.org 
[lkml]   [2012]   [Mar]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/3] dma-buf: add support for kernel cpu access
    From
    On Fri, Mar 2, 2012 at 23:24, Rob Clark <robdclark@gmail.com> wrote:
    > Perhaps we should check somewhere for required dmabuf ops fxns (like
    > kmap_atomic here), rather than just calling unconditionally what might
    > be a null ptr.  At least put it in the WARN_ON(), but it might be
    > nicer to catch a missing required fxns at export time, rather than
    > waiting for an importer to try and call it.  Less likely that way, for
    > newly added required functions go unnoticed.
    >
    > (same comment applies below for the non-atomic variant.. and possibly
    > some other existing dmabuf ops)

    Agreed, I'll rework the patch to do that when rebasing onto Sumit's latest tree.
    -Daniel
    --
    Daniel Vetter
    daniel.vetter@ffwll.ch - +41 (0) 79 365 57 48 - http://blog.ffwll.ch
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-03-05 20:01    [W:0.021 / U:31.004 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site