| Date | Mon, 5 Mar 2012 15:03:27 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: [PATCH 15/68] TTY: ipwireless, fix tty->index handling |
| |
On Mon, 5 Mar 2012, Jiri Slaby wrote:
> * do not test if tty->index is in bounds. It is always. > * tty->index is not a minor! Fix that. > > >From now on, let's assume that the parameter of the function is tty > index with base being zero. This makes also the code more readable. > > Factually, there is no real change as tty_driver->minor_start is zero, > so the tests are equivalent. But it did not make sense. And if this > had changed eventually, it would have caused troubles. > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Jiri Kosina <jkosina@suse.cz> > Cc: David Sterba <dsterba@suse.cz>
Acked-by: Jiri Kosina <jkosina@suse.cz>
Thanks Jiri.
-- Jiri Kosina SUSE Labs
|