Messages in this thread | | | Date | Sat, 31 Mar 2012 11:52:02 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH] tracing: fix the "old_pid" usage in trace_sched_process_exec() |
| |
* Oleg Nesterov <oleg@redhat.com> wrote:
> On 03/30, Oleg Nesterov wrote: > > > > 1. TRACE_EVENT(sched_process_exec) forgets to actually use the > > old pid argument, it sets ->old_pid = p->pid. > > > > 2. search_binary_handler() uses the wrong pid number. tracepoint > > needs the global pid_t from the root namespace, while old_pid > > is the virtual pid number as it seen by the tracer/parent. > > Not really serious, but probably makes sense for 3.4. This fixes > the recently merged 4ff16c25e2cc48cbe6956e356c38a25ac063a64d > "tracepoint, vfs, sched: Add exec() tracepoint"
Thanks Oleg - will queue your fix up in tip:perf/urgent.
Thanks,
Ingo
| |