lkml.org 
[lkml]   [2012]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tracing: fix the "old_pid" usage in trace_sched_process_exec()

* Oleg Nesterov <oleg@redhat.com> wrote:

> On 03/30, Oleg Nesterov wrote:
> >
> > 1. TRACE_EVENT(sched_process_exec) forgets to actually use the
> > old pid argument, it sets ->old_pid = p->pid.
> >
> > 2. search_binary_handler() uses the wrong pid number. tracepoint
> > needs the global pid_t from the root namespace, while old_pid
> > is the virtual pid number as it seen by the tracer/parent.
>
> Not really serious, but probably makes sense for 3.4. This fixes
> the recently merged 4ff16c25e2cc48cbe6956e356c38a25ac063a64d
> "tracepoint, vfs, sched: Add exec() tracepoint"

Thanks Oleg - will queue your fix up in tip:perf/urgent.

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-03-31 11:55    [W:0.040 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site