Messages in this thread | | | From | David Howells <> | Subject | Re: On patch "Remove all #inclusions of asm/system.h" | Date | Sun, 01 Apr 2012 02:46:31 +0100 |
| |
Stefan Richter <stefanr@s5r6.in-berlin.de> wrote:
> It's not a problem; they now get barrier.h via spinlock.h. I just > wondered whether absence of #include <asm/barrier.h> in those files had a > deeper non-obvious meaning. Since it doesn't I will just put that include > in them next time around when I do some housekeeping there.
I suspect they should #include asm/barrier.h directly rather than relying on spinlock.h. There's no guarantee that on every arch spinlock.h will pull in asm/barrier.h, I think...
David
| |