[lkml]   [2012]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] video:uvesafb: Fix oops that uvesafb try to execute NX-protected page
    On 03/27/2012 01:32 PM, Alan Cox wrote:
    > On Tue, 27 Mar 2012 18:01:36 +0800
    > Wang YanQing <> wrote:
    >> Ok! I try to check pcibios_enabled first, but get some opposition by Alan Cox,
    >> but I want to make thing work and fix the oops, so I choice the simple way to
    >> check the (__supported_pte_mask & _PAGE_NX) instead of to check this variable plus
    >> pci kernel boot parameter, pci mmconfig works or not, and more, and more. It is not
    >> the best method, but it works and maybe all will feel happy.

    Wang, could you please write a better commit message, at least you could
    include the oops that your patch fixes.

    > Apart from adding a helper in the includes for the arch code of
    > static inline is_nx_enabled(void)
    > {
    > return !!(__supported_pte_mask & _PAGE_NX);
    > }

    As this check is already done in a few other places I think there should
    be a separate patch that adds this helper and ports all existing code to
    use it.

    So, does anyone have any objection against me taking this patch as is?


    Florian Tobias Schandinat

     \ /
      Last update: 2012-03-31 23:33    [W:0.021 / U:5.528 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site