lkml.org 
[lkml]   [2012]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 148/149] nfsd: dont allow zero length strings in cache_parse()
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 6d8d17499810479eabd10731179c04b2ca22152f upstream.

    There is no point in passing a zero length string here and quite a
    few of that cache_parse() implementations will Oops if count is
    zero.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: J. Bruce Fields <bfields@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    net/sunrpc/cache.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/net/sunrpc/cache.c
    +++ b/net/sunrpc/cache.c
    @@ -828,6 +828,8 @@ static ssize_t cache_do_downcall(char *k
    {
    ssize_t ret;

    + if (count == 0)
    + return -EINVAL;
    if (copy_from_user(kaddr, buf, count))
    return -EFAULT;
    kaddr[count] = '\0';



    \
     
     \ /
      Last update: 2012-03-31 00:07    [W:0.024 / U:0.056 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site