Messages in this thread | | | Date | Fri, 30 Mar 2012 11:50:24 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH 03/17] ARM: mark const init data with __initconst instead of __initdata |
| |
Hello Shawn,
On Fri, Mar 30, 2012 at 02:11:36PM +0800, Shawn Guo wrote: > On Thu, Mar 29, 2012 at 11:12:20PM +0200, Uwe Kleine-König wrote: > ... > > diff --git a/arch/arm/mach-imx/imx51-dt.c b/arch/arm/mach-imx/imx51-dt.c > > index 5cca573..7e00748 100644 > > --- a/arch/arm/mach-imx/imx51-dt.c > > +++ b/arch/arm/mach-imx/imx51-dt.c > > @@ -102,7 +102,7 @@ static struct sys_timer imx51_timer = { > > .init = imx51_timer_init, > > }; > > > > -static const char *imx51_dt_board_compat[] __initdata = { > > +static const char *imx51_dt_board_compat[] __initconst = { > > "fsl,imx51-babbage", > > "fsl,imx51", > > NULL > > CC arch/arm/mach-imx/imx51-dt.o > arch/arm/mach-imx/imx51-dt.c:105:20: error: imx51_dt_board_compat causes a section type conflict > make[2]: *** [arch/arm/mach-imx/imx51-dt.o] Error 1 > > I do not understand why though. that's because the strings are constant, but the array is not. The fix is:
-static const char *imx51_dt_board_compat[] __initconst = { +static const char *const imx51_dt_board_compat[] __initconst = {
or keeping __initdata.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |