lkml.org 
[lkml]   [2012]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 024/149] tty: moxa: fix bit test in moxa_start()
    3.2-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 58112dfbfe02d803566a2c6c8bd97b5fa3c62cdc upstream.

    This is supposed to be doing a shift before the comparison instead of
    just doing a bitwise AND directly. The current code means the start()
    just returns without doing anything.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Jiri Slaby <jslaby@suse.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/tty/moxa.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/tty/moxa.c
    +++ b/drivers/tty/moxa.c
    @@ -1331,7 +1331,7 @@ static void moxa_start(struct tty_struct
    if (ch == NULL)
    return;

    - if (!(ch->statusflags & TXSTOPPED))
    + if (!test_bit(TXSTOPPED, &ch->statusflags))
    return;

    MoxaPortTxEnable(ch);



    \
     
     \ /
      Last update: 2012-03-30 23:13    [W:2.199 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site